Solved Scripting: getChannelGroup() uses cached data

[Ron]

Hi!

Version: SinusBot 0.13.37-9791176
OS: Ubuntu 16.04, latest updates

At the moment, there's a bug with the scripting API (TS3 specifically), where if I try to use getChannelGroup() it'll use cached data,
so if a client switches channel, or someone changes his group, it still returns the old one.

 

[flyth]

Could you please provide a snippet to reproduce that issue?

 

[Ron]

Of course!

Simply message the bot with the command, change his group, and message him again.

registerPlugin({
    name: 'Repro',
    version: '1.0',
    description: 'For reproduction purposes',
    author: 'Ron Melkhior <[email protected]>',
}, init);

function init(sinusbot, config) {
    var event = require('event');
    var engine = require('engine');
    var backend = require('backend');

    var g_client = backend.getBotClient();

    event.on('chat', onMessageReceived);
    event.on('connect', onConnectServer);

    function onMessageReceived(message) {
        if (message.text === '!checkgroup') {
            message.client.chat(g_client.getChannelGroup().name());
        }
    }

    function onConnectServer() {
        g_client = backend.getBotClient();
    }
}

 

[irgendwr]

Yep can confirm btw.

event.on('chat', function (ev) {
    if (ev.text == "!foo") {
        ev.client.chat(ev.client.getChannelGroup().name());
    }
});

 

[flyth]

Okay, that example saves a copy of a client object from one event and uses it in another. So the caching there is actually intended, so that working with those objects is cheap and doesn't require costly lookups and such.
You could get a new client object by it's id using the id of the cached one to get up to date data. Maybe I'll add an update() function that refreshes the object itself / returns an updated one.

Does that make sense?

 

[Ron]

That example was a basic one, it also happens when trying to access Message.client, which supposedly should be "fresh".
I also just tested, and re-fetching the client using the ID like below does not work either:

registerPlugin({
    name: 'Repro',
    version: '1.0',
    description: 'For reproduction purposes',
    author: 'Ron Melkhior <[email protected]>',
}, init);

function init(sinusbot, config) {
    var event = require('event');
    var engine = require('engine');
    var backend = require('backend');

    var g_client = backend.getBotClient();

    event.on('chat', onMessageReceived);
    event.on('connect', onConnectServer);

    function onMessageReceived(message) {
        var client = backend.getClientByID(message.client.id());

        if (message.text === '!checkgroup') {
            message.client.chat(client.getChannelGroup().name());
        }
    }

    function onConnectServer() {
        g_client = backend.getBotClient();
    }
}

 

[flyth]

Okay, thats definitely a bug then. Will check. Thanks!

 

[GowLi]

still an existing problem
17.02.2019

 

[Ron]

Weird, an update a couple of months ago fixed the issue for me. What version are you running?

 

[GowLi]

SinusBot 0.13.37-f37f203 (Windows)

Please look:
https://forum.sinusbot.com/threads/getchannelgroup-dont-update.6669/

Thanks in advance!

 

[GowLi]

#edit my Linux Version 0.14.3-0e747fd works!!