DB.connect error (or misdocumented)

[Mmoi]

Hi,

I just went through an error in the database connect function.
It does call the callback only on error.
Doc

callback (function) Callback gets called on success / error; If an error occured, exactly one parameter containing the error will be handed to the callback

So, when there is a success, we can't know it without dirty checks (for example for creating needed tables or views). And moreover: it's asynchronous (the bad one, the one that doesn't use promesses (as of ECMAScript 6))

I'm using sinusbot v.0.13.37-9791176 (current stable at the time of download)

Just to let you know
Mmoi

 

[irgendwr]

And moreover: it's asynchronous (the bad one, the one that doesn't use promesses (as of ECMAScript 6))

We can't use promises since the engine uses es5.

Can't test the callback thing right now but if it doesn't work it's a bug, thank you for reporting it.

 

[Mmoi]

I have a second question: can we make a synchronous query?

 

[Mmoi]

Following the process, creating a lot a querys / execs results at a sinusbot crash (globally, not just the script).
If you're interested in looking the logs, please tell me.

 

[flyth]

Could you please send the logs via PM? Will look into the issue.

 

[Mmoi]

Could you please send the logs via PM? Will look into the issue.

Will do once I’m home